feat(api): relabel columns to ALL_CAPS

[IndexSeek]

Using "snake_case" has been a useful short-hand as was implemented in #5336. In addition to "snake_case" I wanted to add support for "screaming_snake_case". Some systems, such as Snowflake, Oracle SQL, and PL/SQL follow this sort of convention.

I think this would be a worthwhile addition that might help when working with different backends or databases that treat double-quoted identifiers as case-insensitive.

https://en.wikipedia.org/wiki/Snake_case

https://docs.snowflake.com/en/sql-reference/identifiers-syntax#migrating-from-databases-that-treat-double-quoted-identifiers-as-case-insensitive

[lostmygithubaccount]

should it be "SCREAMING_SNAKE_CASE"?

[IndexSeek]

should it be "SCREAMING_SNAKE_CASE"?

I thought about this, as that makes sense, as it's usually how it's stylized. I'm happy to make that tweak if that's how it would be preferred to be referenced.

It looks like it could also be referred to as the following:

• ALL_CAPS
• MACRO_CASE
• CONSTANT_CASE

But in each case, the styling is all caps, as you mention.

[cpcloud]

@IndexSeek Nice, thanks for the PR.

Can we go with ALL_CAPS? SCREAMING_SNAKE_CASE is kind of a handful to type and ideally we can keep these shorthands ... short 😂.

[IndexSeek]

@IndexSeek Nice, thanks for the PR.

Can we go with ALL_CAPS? SCREAMING_SNAKE_CASE is kind of a handful to type and ideally we can keep these shorthands ... short 😂.

Definitely! I have made that change now and agree, short and simple. I thought the original "snake_case" short-hand was really handy; I'm hoping this version of it will also be convenient, especially for going between backends.

[cpcloud]

@IndexSeek You may want to disable GitHub Actions on your fork. I believe that will cause a bit of CI congestion for you since you'll be running every job twice: once against the main ibis repo and once against your fork.

[cpcloud]

@IndexSeek I think there may be a whitespace change picked up by the markdown autoformatter. I'll fix it up.

[cpcloud]

Hm, looks like I can't push to the branch because it's master (I can only push to non-master branches).

[IndexSeek]

@IndexSeek You may want to disable GitHub Actions on your fork. I believe that will cause a bit of CI congestion for you since you'll be running every job twice: once against the main ibis repo and once against your fork.

This is a good call, disabled them now, that'll help keep my email inbox a little cleaner as well.

@IndexSeek I think there may be a whitespace change picked up by the markdown autoformatter. I'll fix it up.
Hm, looks like I can't push to the branch because it's master (I can only push to non-master branches).

I've made the whitespace fix now, thank you for looking at that and attempting to fix it. I should have just made a feature branch on my fork. Hopefully it is good now, checks are still queued as I'm commenting.

[jcrist]

One small type annotation nit, otherwise this looks good to me!

Could you please squash your commits together into a single commit (with a message something like "feat(api): add ALL_CAPS option to Table.relabel"). We generate our changelog from commit messages, so we're a bit picky here about this.

[jcrist]

Suggested change

	| Literal["snake_case"]
	| Literal["ALL_CAPS"],
	| Literal["snake_case", "ALL_CAPS"],

[IndexSeek]

I've opened #6543 to squash those commits and try this again. I truly appreciate all of your patience and support. I understand wanting to keep things simple with the CHANGELOG.

As I'm commenting on this, I realize I must combine the Literal typing as was suggested above.