Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ir): rename .output_dtype and .output_shape to .dtype and .shape respectively #6614

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented Jul 10, 2023

Depends on #5899

prefer shorter names for these attributes, aliases are provided for backwards compatibility but they are deprecated

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@kszucs kszucs force-pushed the dtype-shape branch 2 times, most recently from 61469ba to 8fccfca Compare July 11, 2023 12:06
@kszucs kszucs changed the base branch from master to 7.x.x July 11, 2023 12:06
@kszucs kszucs force-pushed the dtype-shape branch 2 times, most recently from c3b7ff7 to 60144e2 Compare July 19, 2023 13:41
@kszucs
Copy link
Member Author

kszucs commented Jul 19, 2023

@cpcloud rebased it since #5899 has been merged

@kszucs kszucs force-pushed the dtype-shape branch 3 times, most recently from 11d9140 to d340168 Compare July 20, 2023 09:49
@kszucs kszucs requested a review from cpcloud July 20, 2023 09:52
ibis/common/typing.py Outdated Show resolved Hide resolved
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, much nicer!

@cpcloud cpcloud added this to the 7.0 milestone Jul 20, 2023
@cpcloud cpcloud added refactor Issues or PRs related to refactoring the codebase datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) labels Jul 20, 2023
…and `.shape` respectively

prefer shorter names for these attributes, aliases are provided for backwards compatibility but they are deprecated
@cpcloud cpcloud merged commit bf8a965 into ibis-project:7.x.x Jul 20, 2023
95 of 96 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants