test: add more weird join predicate tests #7424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
approved these changes
Oct 24, 2023
|
I think we can probably address point 2, but if we can hold off until 8.0 that would be ideal as there are some other refactors of joins happening right now. Is that okay? |
|
@NickCrews Would you mind changing the commit message to be a bit more specific than |
cpcloud
added
ux
|
I will change the commit message and add to the docs. Sounds good on the 8.0 target! |
As I was exploring ibis-project#6506, I discovered that there are join predicate types that currently work, but aren't tested for. This commits adds tests for those predicate types.
cpcloud
force-pushed
the
more-join-predicates
branch
from
a11b23d to
aa949fb
Compare
cpcloud
approved these changes
Oct 26, 2023
|
@NickCrews I updated the commit message! Please open the docs changes in a separate PR. Looking forward to them! |
|
Thanks! Im mostly out of office the next few weeks so I will be slow to respond. Looks great. |
NickCrews
added a commit
to NickCrews/ibis
that referenced
this pull request
Oct 30, 2023
followup to ibis-project#7424
NickCrews
added a commit
to NickCrews/ibis
that referenced
this pull request
Oct 31, 2023
followup to ibis-project#7424
NickCrews
added a commit
to NickCrews/ibis
that referenced
this pull request
Oct 31, 2023
followup to ibis-project#7424
NickCrews
added a commit
to NickCrews/ibis
that referenced
this pull request
Nov 1, 2023
followup to ibis-project#7424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6506
As I was exploring #6506,
I deiscovered that there were all these join predicate
types that currenty work,
but only sort of "accidentally", and they
aren't actually tested for. This adds
tests for those.
Still TODO is to
[(_.col_in_left.upper(), _.col_in_right.upper())]instead of merely(_.col_in_left.upper(), _.col_in_right.upper()), because the iterable of conditions gets promoted to a list, so ibis thinks the user really means two join keys:[_.col_in_left.upper(), _.col_in_right.upper()]. I would love to remove the need for this outer list. Could we add a special case where if keys is a tuple of length 2, then assume this is a single join key, and don'tutil.promote_list()it?