fix(duckdb): allow table creation from expr with geospatial datatypes #7818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought, initially, that `WKB_BLOB` should be mapped on to something like `dt.GeoSpatial`, but that leads to a situation where we try to call `AsWKB` on an existing WKB column, and DuckDB does not like that. Mapping it as `binary` works and the created columns are still correctly detected as `geometry:geospatial`.
cpcloud
reviewed
Dec 20, 2023
cpcloud
approved these changes
Dec 20, 2023
cpcloud
added
bug
Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
|
Oh right, we can click update now and let squash merging take care of the commits :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought, initially, that
WKB_BLOBshould be mapped on to somethinglike
dt.GeoSpatial, but that leads to a situation where we try to callAsWKBon an existing WKB column, and DuckDB does not like that.Mapping it as
binaryworks and the created columns are still correctlydetected as
geometry:geospatial.