fix(backends): preserve order_by position in window function when subsequent expressions are duplicated
#7943
+41
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
bug
|
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
cpcloud
force-pushed
the
bq-window-ordering-bug
branch
from
4392e69 to
7074346
Compare
cpcloud
changed the title
order_by order when duplicates are introduced in subsequent expressions
cpcloud
force-pushed
the
bq-window-ordering-bug
branch
from
7074346 to
edde859
Compare
cpcloud
force-pushed
the
bq-window-ordering-bug
branch
from
edde859 to
e25564c
Compare
cpcloud
changed the title
order_by order when duplicates are introduced in subsequent expressionsorder_by position in window function when subsequent expressions are duplicated
…d when duplicates are introduced
cpcloud
force-pushed
the
bq-window-ordering-bug
branch
from
e25564c to
1082ea1
Compare
kszucs
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR fixes an issue where duplicate window expressions were given the position of the new (duplicated value)
of the expression, rather than preserving the original order.
This was because we were iterating over the new keys first and putting those expressions into a
dict.BY iterating over the old keys first, we preserve the original order.
Issues closed
Closes #7940.