Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ir): accept any relation in ops.ExistsSubquery #8264

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented Feb 7, 2024

Also move the subquery operations to a separate file.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@cpcloud cpcloud changed the title refactor(ir): accept any relation in ops.ExistsSubquery refactor(ir): accept any relation in ops.ExistsSubquery Feb 7, 2024
@cpcloud
Copy link
Member

cpcloud commented Feb 7, 2024

Whatever is creating your PR titles is throwing extra whitespace on the end, which isn't allowed :)

@kszucs
Copy link
Member Author

kszucs commented Feb 7, 2024

Whatever is creating your PR titles is throwing extra whitespace on the end, which isn't allowed :)

gh :)

@cpcloud cpcloud added this to the 9.0 milestone Feb 7, 2024
@cpcloud cpcloud enabled auto-merge (squash) February 7, 2024 19:48
@cpcloud cpcloud merged commit 5b7f739 into ibis-project:the-epic-split Feb 7, 2024
69 checks passed
@kszucs kszucs deleted the exists-subquery branch February 7, 2024 19:53
cpcloud pushed a commit to cpcloud/ibis that referenced this pull request Feb 12, 2024
cpcloud pushed a commit to cpcloud/ibis that referenced this pull request Feb 12, 2024
ncclementi pushed a commit to ncclementi/ibis that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants