refactor(sql): move dialects to always-importable location #8279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
refactor
cpcloud
force-pushed
the
consolidate-dialects
branch
7 times, most recently
from
2891c5d
to
53ad3e2
Compare
cpcloud
force-pushed
the
consolidate-dialects
branch
from
53ad3e2
to
b8d2b55
Compare
cpcloud
commented
Feb 8, 2024
|
Gah, I keep forgetting we don't have CI blocking on the-epic-split. Enabling that now. |
cpcloud
added a commit
to cpcloud/ibis
that referenced
this pull request
Feb 12, 2024
cpcloud
added a commit
that referenced
this pull request
Feb 12, 2024
cpcloud
added a commit
to cpcloud/ibis
that referenced
this pull request
Feb 12, 2024
cpcloud
added a commit
that referenced
this pull request
Feb 12, 2024
kszucs
pushed a commit
that referenced
this pull request
Feb 12, 2024
ncclementi
pushed a commit
to ncclementi/ibis
that referenced
this pull request
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates our dialects into a single file (
ibis/backends/base/sqlglot/dialects) to allow reuse without implicitly needing to import drivers or other backend-specific dependencies.