Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(risingwave): add backend docs page for RisingWave #8286

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

gforsyth
Copy link
Member

@gforsyth gforsyth commented Feb 8, 2024


Description of changes

Adds a backend docs page for the RisingWave backend.

Issues closed

Copy link
Member

@lostmygithubaccount lostmygithubaccount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor things

:::


### Connection Parameters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be "Connection parameters" per style guide (but seeing it's this for all the other backends, so maybe keep + fix this in a future PR)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, can handle that in a followup

```

::: {.callout-note}
`ibis.risingwave.connect` is a thin wrapper around [`ibis.backends.risingwave.Backend.do_connect`](#ibis.backends.risingwave.Backend.do_connect).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap line?

@lostmygithubaccount
Copy link
Member

cc: @KeXiangWang

@lostmygithubaccount lostmygithubaccount added docs Documentation related issues or PRs docs-preview Add this label to trigger a docs preview labels Feb 8, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Feb 8, 2024
@cpcloud cpcloud added this to the 9.0 milestone Feb 8, 2024
@cpcloud cpcloud added the risingwave The RisingWave backend label Feb 8, 2024
@gforsyth gforsyth merged commit a6e7920 into ibis-project:main Feb 8, 2024
21 of 22 checks passed
@gforsyth gforsyth deleted the risingwave_docs branch February 8, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related issues or PRs risingwave The RisingWave backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants