refactor(benchmarks): remove pandas benchmarking and replace with more-representative duckdb version #8322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-representative duckdb version
cpcloud
added
refactor
kszucs
approved these changes
Feb 12, 2024
ncclementi
pushed a commit
to ncclementi/ibis
that referenced
this pull request
Feb 21, 2024
…e-representative duckdb version (ibis-project#8322) This PR removes pandas execution benchmarks, whose performance has gotten much worse after `the-epic-split` merge. IMO, there are good reasons to avoid benchmarking backend execution in Ibis, the main one being that execution is not a part of Ibis that we can control. That isn't true of the Pandas backend, but since the DuckDB backend can now do everything the pandas backend could do after merging `the-epic-split` --including `asof_join`--we are not going to spend any time improving the performance of the pandas backend, I would actually vote to remove all execution tests here, and keep only the ones that benchmark expression compilation and construction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes pandas execution benchmarks, whose performance has gotten much
worse after
the-epic-splitmerge.IMO, there are good reasons to avoid benchmarking backend execution in Ibis,
the main one being that execution is not a part of Ibis that we can control.
That isn't true of the Pandas backend, but since the DuckDB backend can now do
everything the pandas backend could do after merging
the-epic-split--including
asof_join--we are not going to spend any time improving theperformance of the pandas backend,
I would actually vote to remove all execution tests here, and keep only the
ones that benchmark expression compilation and construction.