Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add a uuid function for returning a new uuid #8438

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

jcrist
Copy link
Member

@jcrist jcrist commented Feb 23, 2024

Fixes #8257.

We implemented a bunch of these in a pairing session - there are still a few lingering backends that we should be able to support (but weren't added in this PR):

  • mssql, flink, pyspark, datafusion, and oracle (through existing SQL functions)
  • pandas, dask, maybe polars (through shelling out to a python udf)

@jcrist
Copy link
Member Author

jcrist commented Feb 23, 2024

@jitingxu1 & @ncclementi - I pushed up what we did in the pairing session (plus a few ones after). I suggest we try to get this in and have y'all push up a follow-up adding the remaining backends.

Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cpcloud cpcloud added the feature Features or general enhancements label Feb 23, 2024
@cpcloud cpcloud added this to the 9.0 milestone Feb 23, 2024
@cpcloud cpcloud merged commit 965b6d9 into ibis-project:main Feb 23, 2024
76 checks passed
@jcrist jcrist deleted the create-uuid branch February 24, 2024 00:47
gforsyth pushed a commit that referenced this pull request Mar 7, 2024
Continued from [PR](#8438): 
add uuid operation for mssql, flink,  datafusion,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: expose a function for generating a new uuid
2 participants