Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rewrites): change TableColumn -> Field in rewrites #8448

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix(rewrites): change TableColumn -> Field in rewrites #8448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ibis/expr/rewrites.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@

selections = []
for name in _.parent.schema.names:
col = ops.TableColumn(_.parent, name)
col = ops.Field(_.parent, name)

Check warning on line 53 in ibis/expr/rewrites.py

View check run for this annotation

Codecov / codecov/patch

ibis/expr/rewrites.py#L53 

Added line #L53 was not covered by tests
if (value := mapping.get(name)) is not None:
col = ops.Alias(ops.Coalesce((col, value)), name)
selections.append(col)
Expand All @@ -62,7 +62,7 @@
def rewrite_dropna(_):
"""Rewrite DropNa expressions to use more common operations."""
if _.subset is None:
columns = [ops.TableColumn(_.parent, name) for name in _.parent.schema.names]
columns = [ops.Field(_.parent, name) for name in _.parent.schema.names]
else:
columns = _.subset

Expand Down
Loading