-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add describe
method to compute summary stats of table expressions
#8739
feat(api): add describe
method to compute summary stats of table expressions
#8739
Conversation
@cpcloud soft ping for the second review after rewriting the implementation. Thanks a lot for your feedback and time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for this somewhere? Ideally wherever we test the info method (I think this is in test_generic.py
).
Changes made:
TODOs:
Other backends require both mode and quantile: "datafusion", "impala", "trino", "mysql", "mssql", "trino", "flink" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll rebase it and merge on green.
dadd142
to
49d966f
Compare
describe
method to compute summary stats of table expressions
Description of changes
Add summary stats for a table. Only calculate stats for numeric, string, and bool columns.
For numeric columns:
For category columns:
For Boolean columns:
My questions:
execute()
here. I have another way to implement this, but have to handle the null columns.info()
Issues closed
Resolves #8459