feat(common): add Node.find_below()
methods to exclude the root node from filtering
#8861
+55
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are unable to locate certain values under a relation while applying a value filter because the root node gets filtered out, like:
Used in practice at #8825
Which can be simplified to
_.find_below() or _.parent.find_below()
after this feature.I am not that satisfied with the name, but marked as experimental so we can change it anytime.
This feature will also help with pretty printing the dereference mapping without traversing the dictionary keys in
_flatten_collections()
.