fix(duckdb): workaround remaining null map issues #8985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
force-pushed
the
more-null-map-workarounds
branch
3 times, most recently
from
1894fb1
to
a81bba3
Compare
BREAKING CHANGE: Calling the `get` or `contains` method on `NULL` map values now returns `NULL`. Use `coalesce(map.get(...), default)` or `coalesce(map.contains(), False)` to get the previous behavior.
cpcloud
force-pushed
the
more-null-map-workarounds
branch
from
a81bba3
to
c81a755
Compare
cpcloud
added
the
breaking change
|
Seems like the chocolatey package server is having a moment. |
gforsyth
approved these changes
Apr 17, 2024
|
Ahh, the sqlite failures are chocolatey, but Flink looks like a test failure |
|
xfailed the single failing flink test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8632.
Note that of the backends that support nullable maps, DuckDB is the only one whose
NULLhandling semantics differ.Other backends that support nullable maps and are implemented in Ibis and tested in CI:
hstoreextension)BREAKING CHANGE: Calling the
getorcontainsmethod onNULLmap values now returnsNULL. Usecoalesce(map.get(...), default)orcoalesce(map.contains(), False)to get the previous behavior.