feat(ir): support pretty printing arbitrary traversable objects #9043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszucs
commented
Apr 23, 2024
| @@ -259,3 +260,21 @@ class Coercible(Abstract): | |||
| @classmethod | |||
| @abstractmethod | |||
| def __coerce__(cls, value: Any, **kwargs: Any) -> Self: ... | |||
|
|
|||
|
|
|||
| def get_defining_frame(obj): | |||
There was a problem hiding this comment.
Perhaps not the typing module is the best place for this, but we don't have an inspect module here yet. We can reorganize later since these are designed for public use.
cpcloud
approved these changes
Apr 25, 2024
cpcloud
added
feature
kszucs
added a commit
that referenced
this pull request
Apr 25, 2024
#8992) Enables to use fields from parent tables of the join right hand side instead of enforcing to use the same exact table: ```py t1 = ibis.table(name="t1", schema={"a": "int64", "b": "string"}) t2 = ibis.table(name="t2", schema={"c": "int64", "d": "string"}) t3 = t2.mutate(e=t2.c + 1) joined = t1.join(t3, [t1.a == t2.c]) # here we use t2.c instead of t3.c ``` Identify ambiguous cases and raise an error, like the following case: ```py t.join(t, [t.a == t.a]) ``` depends on: - #9043 - #9041 fixes #8581
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables pretty formatting the dereference mappings and also the replacements mappings we use in rewrites for better inspection. Also moved the irrelevant logic out from
format.py.