refactor(udf): remove hierarchical usage of schema #9078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforsyth
force-pushed
the
gil/udf_database_schema
branch
from
9380096 to
0f9fcc5
Compare
BREAKING CHANGE: The `schema` parameter for UDF definition has been removed. A new `catalog` parameter has been added. Ibis uses the word database to refer to a collection of tables, and the word catalog to refer to a collection of databases. You can use a combination of `catalog` and `database` to specify a hierarchical location for the UDF.
gforsyth
force-pushed
the
gil/udf_database_schema
branch
from
0f9fcc5 to
b42337d
Compare
cpcloud
approved these changes
Apr 30, 2024
cpcloud
added
refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not deprecate
schemaas we have elsewhere, because I don't think we candetermine the quoting behavior of the backend at UDF definition time, which
makes accepting dotted string paths harder.
BREAKING CHANGE: The
schemaparameter for UDF definition has been removed. A newcatalogparameter has been added. Ibis uses the word database to refer to a collection of tables, and the word catalog to refer to a collection of databases. You can use a combination ofcataloganddatabaseto specify a hierarchical location for the UDF.