Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): make icon grayscale for consistency #9100

Merged
merged 1 commit into from
May 2, 2024

Conversation

deepyaman
Copy link
Contributor

@deepyaman deepyaman commented May 2, 2024

Description of changes

New

image

Old

image

@deepyaman deepyaman added the docs-preview Add this label to trigger a docs preview label May 2, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label May 2, 2024
@lostmygithubaccount
Copy link
Member

can let Phillip speak for himself but he mentioned that he liked having it stand out at one point (personally I'm in favor of making it grey, but not a super strong opinion)

@deepyaman
Copy link
Contributor Author

can let Phillip speak for himself but he mentioned that he liked having it stand out at one point (personally I'm in favor of making it grey, but not a super strong opinion)

Got it. Free for him to close then, if left intentionally blue.

@ibis-docs-bot
Copy link

ibis-docs-bot bot commented May 2, 2024

@deepyaman deepyaman requested a review from cpcloud May 2, 2024 01:28
@cpcloud
Copy link
Member

cpcloud commented May 2, 2024

Seems fine!

@cpcloud cpcloud merged commit fb81f92 into ibis-project:main May 2, 2024
21 checks passed
@cpcloud cpcloud added this to the 9.1 milestone May 2, 2024
@deepyaman deepyaman deleted the patch-6 branch May 12, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants