Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(duckdb): clean up temp view junk when using memtables in create_table #9107

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented May 2, 2024

QoL improvement for loading from in-memory data: no more temporary view junk.

@cpcloud cpcloud added this to the 9.1 milestone May 2, 2024
@cpcloud cpcloud added ux User experience related issues duckdb The DuckDB backend labels May 2, 2024
@cpcloud cpcloud requested a review from gforsyth May 2, 2024 16:46
@cpcloud
Copy link
Member Author

cpcloud commented May 2, 2024

This happens in most backends, I'll tackle the rest in a follow up.

@gforsyth
Copy link
Member

gforsyth commented May 2, 2024

This happens in most backends, I'll tackle the rest in a follow up.

hah, I was just fighting with this in MSSQL

@gforsyth gforsyth enabled auto-merge (squash) May 2, 2024 16:57
@gforsyth gforsyth merged commit 4e7a00c into ibis-project:main May 2, 2024
96 checks passed
@cpcloud cpcloud deleted the cleanup-duckdb-memtable-views-in-create-table branch May 2, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duckdb The DuckDB backend ux User experience related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants