Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snowflake): implement support for asof_join API #9180

Merged
merged 1 commit into from
May 13, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented May 13, 2024

Adds support for asof_join to the Snowflake backend.

Depends on #9181.

@cpcloud cpcloud added this to the 9.1 milestone May 13, 2024
@cpcloud cpcloud added feature Features or general enhancements snowflake The Snowflake backend labels May 13, 2024
@cpcloud cpcloud requested review from kszucs and gforsyth May 13, 2024 11:18
@cpcloud
Copy link
Member Author

cpcloud commented May 13, 2024

This is in draft mode because there's some apparently incorrect timestamp conversion happening somewhere. Fixed in #9181.

@cpcloud cpcloud marked this pull request as ready for review May 13, 2024 11:51
@cpcloud cpcloud force-pushed the snowflake-asof-join branch from b906924 to 7601edf Compare May 13, 2024 12:30
@cpcloud
Copy link
Member Author

cpcloud commented May 13, 2024

Going to split out the Parquet timestamp fix into a separate PR.

@cpcloud cpcloud force-pushed the snowflake-asof-join branch 2 times, most recently from d2b1614 to 383c26d Compare May 13, 2024 13:29
@cpcloud
Copy link
Member Author

cpcloud commented May 13, 2024

Snowflake is passing all as of join tests:

…/ibis on  snowflake-asof-join is 📦 v9.0.0 via 🐍 v3.12.2 via ❄️   impure (ibis-3.12.2-env)
❯ pytest -m snowflake ibis/backends/tests/test_asof_join.py -vv
======================================================================================== test session starts =========================================================================================
platform linux -- Python 3.12.2, pytest-8.2.0, pluggy-1.5.0 -- /nix/store/h1gvc0gq3awn43bf6bbbzjciydwv232i-python3-3.12.2-env/bin/python3.12
cachedir: .pytest_cache
benchmark: 4.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
Using --randomly-seed=3549411145
collected 80 items / 76 deselected / 4 selected

ibis/backends/tests/test_asof_join.py::test_asof_join[snowflake-forward-le] PASSED [ 25%]
ibis/backends/tests/test_asof_join.py::test_asof_join[snowflake-backward-ge] PASSED [ 50%]
ibis/backends/tests/test_asof_join.py::test_keyed_asof_join_with_tolerance[snowflake-backward-ge] PASSED [ 75%]
ibis/backends/tests/test_asof_join.py::test_keyed_asof_join_with_tolerance[snowflake-forward-le] PASSED [100%]

================================================================================= 4 passed, 76 deselected in 28.17s ==================================================================================

Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cpcloud cpcloud force-pushed the snowflake-asof-join branch from 383c26d to d1ccd71 Compare May 13, 2024 14:20
@cpcloud cpcloud enabled auto-merge (squash) May 13, 2024 14:20
@cpcloud cpcloud merged commit 49c6ce3 into ibis-project:main May 13, 2024
82 checks passed
@cpcloud cpcloud deleted the snowflake-asof-join branch May 13, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements snowflake The Snowflake backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants