Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(arrays): add array repeat test on column expression #9182

Merged
merged 3 commits into from
May 13, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented May 13, 2024

Follow up to #9177 that adds a test for repeating a column array.

@cpcloud cpcloud added this to the 9.1 milestone May 13, 2024
@cpcloud cpcloud added the tests Issues or PRs related to tests label May 13, 2024
@cpcloud cpcloud force-pushed the revert-array-repeat-removal branch from 29395e7 to a6ae4bf Compare May 13, 2024 13:22
@cpcloud cpcloud requested a review from gforsyth May 13, 2024 13:24
@cpcloud
Copy link
Member Author

cpcloud commented May 13, 2024

Apologies for the churn 😬

@cpcloud cpcloud force-pushed the revert-array-repeat-removal branch from a6ae4bf to 891ba3d Compare May 13, 2024 13:27
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, at least we noticed it quickly!

Confimed that the new test is currently failing on main and passes here.

:shipit:

@cpcloud cpcloud force-pushed the revert-array-repeat-removal branch from a8541e6 to 761adf4 Compare May 13, 2024 14:19
@cpcloud cpcloud enabled auto-merge (squash) May 13, 2024 14:19
@cpcloud cpcloud merged commit bee1da5 into ibis-project:main May 13, 2024
82 checks passed
@cpcloud cpcloud deleted the revert-array-repeat-removal branch May 13, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants