-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drop Python 3.9 and test on Python 3.10/3.12 #9213
feat: drop Python 3.9 and test on Python 3.10/3.12 #9213
Conversation
e6740c2
to
7187b22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks (mostly) good to me. There are two (kinds) of changes made by pyupgrade that I'd like to revert, but the CI and metadata updates look good to me.
b4d6aa3
to
928eaa1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provided tests pass, this looks good to me! We should get a review by one other person before merging (@gforsyth?) just to ensure I didn't miss anything around the CI setup.
FYI tests have passed; the required nix 3.9 test just won't complete, because it's removed. |
I'll remove the required nix 3.9 test |
@jcrist @deepyaman I think historically we made this a breaking change. Should we considering changing that convention? |
I think that dropping a Python version in a minor release seems fine (it's also pretty common in the ecosystem). Since we've updated the minimum version requirement, even pip's solver won't allow them to install the new release with an older version of python. The "breakage" here isn't something a user should be able to encounter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Can we make this a feature or fix PR?
a51f884
to
69d627f
Compare
Done! Also rebased. |
69d627f
to
9483cf2
Compare
Description of changes
According to NEP-29, we could have dropped Python 3.9 last month.
pyupgrade
rules to remove code for Python<3.10.Issues closed
N/A