-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(all): enable passing in-memory data to create_table #9251
Merged
gforsyth
merged 24 commits into
ibis-project:main
from
gforsyth:ibis-create-table-in-memory
May 29, 2024
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
e9e0adc
refactor(duckdb): add polars df as option, move test to backend suite
gforsyth 1c6833d
feat(polars): enable passing in-memory data to create_table
gforsyth 68a6c3c
feat(datafusion): enable passing in-memory data to create_table
gforsyth 28231bd
feat(datafusion): use info_schema for list_tables
gforsyth 0b3ea31
feat(duckdb): enable passing in-memory data to create_table
gforsyth 66d2fb7
feat(postgres): allow passing in-memory data to create_table
gforsyth 819abd1
feat(trino): allow passing in-memory date to create_table
gforsyth 13bd22f
feat(mysql): allow passing in-memory data to create_table
gforsyth 7545abf
feat(mssql): allow passing in-memory data to create_table
gforsyth c6815e7
feat(exasol): allow passing in-memory data to create_table
gforsyth 7fe4130
feat(risingwave): allow passing in-memory data to create_table
gforsyth 8ddcd9a
feat(sqlite): allow passing in-memory data to create_table
gforsyth 235c03f
feat(clickhouse): enable passing in-memory data to create_table
gforsyth 4486097
feat(oracle): enable passing in-memory data to create_table
gforsyth 59b8b73
feat(snowflake): allow passing in-memory data to create_table
gforsyth a17e76e
feat(pyspark): enable passing in-memory data to create_table
gforsyth 0219d63
feat(pandas,dask): allow passing in-memory data to create_table
gforsyth 2f9252b
chore: apply suggestions
gforsyth f65379d
chore(polars,datafusion): remove nascent `read_in_memory`
gforsyth e9fef1c
feat(bigquery): allow passing in-memory data to create_table
gforsyth fe6b114
feat(impala): allow passing in-memory data to create_table
gforsyth a1d9227
test(create_table): create initial memtable on backend being tested
gforsyth 4e45c10
test(create_table): use lambdas for all inputs
gforsyth 9a3a698
chore(ci): add polars to mysql, mssql, and oracle
gforsyth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this could be ibis.memtable()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, and that would unify the implementations across the backends, too. I'll open an follow-up to make use of the lazy single-dispatching for memtable insertion for the in-process backends.