Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(bigquery): avoid running list_tables when registering memtables #9425

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jun 21, 2024

Closes #9216.

@cpcloud cpcloud added this to the 9.2 milestone Jun 21, 2024
@cpcloud cpcloud added performance Issues related to ibis's performance bigquery The BigQuery backend labels Jun 21, 2024
@cpcloud cpcloud requested a review from jcrist June 21, 2024 17:57
ibis/backends/bigquery/__init__.py Show resolved Hide resolved
@cpcloud
Copy link
Member Author

cpcloud commented Jun 21, 2024

BigQuery looking good:

cloud in 🌐 falcon in …/ibis on  faster-bigquery-memtables is 📦 v9.1.0 via 🐍 v3.10.14 via ❄️   impure (ibis-3.10.14-env) took 24s
❯ pytest -m bigquery -n auto --dist loadgroup
====================================================================== test session starts ======================================================================
platform linux -- Python 3.10.14, pytest-8.2.2, pluggy-1.5.0
benchmark: 4.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
Using --randomly-seed=1778153405
rootdir: ...
configfile: pyproject.toml
plugins: benchmark-4.0.0, timeout-2.3.1, xdist-3.6.1, hypothesis-6.103.2, repeat-0.9.3, randomly-3.15.0, clarity-1.0.1, anyio-4.4.0, cov-5.0.0, pytest_httpserver-1.0.10, mock-3.14.0, snapshot-0.9.0
32 workers [1937 items]
.....................................ssssssssssssssssssssss..................x..x..........................x......x.x.x.xxx.x..xxxxx...xxx......xx..xxxx. [  7%]
..x.x.....x..x..x.....xx....x.......x.........x..x....................x.............x.........x........x.x...........x........x.......x.................. [ 15%]
................xx..................x....x..x....x.....xx.x.....x..x..x..............x...........x.xx......x.x.............xx..x.....x.....x.......x..... [ 23%]
.x.............x..x...............xx.....x....x....x........x..x.x....x......xx..x..........x.xx....xx...........x.x....x........x...x.x...x..........x.x [ 31%]
........x..........x....x.......x.x.....xx.....x.........x..x.........x....x..........xxxxxxxx...x...xx......x...x.x.x.x.xx..x.x..x.....x....x...x.x...x. [ 39%]
.x........xx.........x.x...x........xx.x...........x.......xx.x.................x..........x...xxx..........x.x.........x.x............x...x.....s....... [ 47%]
.......xx...x...sx.x.x...x....s.....x.x......x...x..........x.......s.........................x........................................x................. [ 55%]
..............x...............................x..........x....x.x.xxxxxx.xxx....xx.xx.xx..xxx..xxxx..x.xxx.xxxxxxx.xxx.x.xxxxxxxxxxxxxxxxxx.xxx.xx.xxxxxx [ 63%]
xxxxxxxxxxxxxxxxxxxxxxxxx.xx..xxx.xxxxxxx.xxxxxxxxs....x....x.x.x...x.....s...................x........x.x..............xxx....x.x..x.x..x.x.....x.x...x. [ 71%]
x..........s........x.....xx.....x.......x..x....x..x........x.....xx.........................xx...x..............x.x..........x........x..x..x........x. [ 78%]
.............................................................................................................................x........................... [ 86%]
............x...................................x..................................................................................x.....x............... [ 94%]
...........................x............................................x...................s........                                                     [100%]
=================================================== 1570 passed, 30 skipped, 337 xfailed in 250.66s (0:04:10) ===================================================

@cpcloud cpcloud merged commit fbc79d2 into ibis-project:main Jun 21, 2024
74 checks passed
@cpcloud cpcloud deleted the faster-bigquery-memtables branch June 21, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bigquery The BigQuery backend performance Issues related to ibis's performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: create_table(temp=True) timing out due to slow table existence check
2 participants