Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): allow grouping by scalar values #9451

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jun 27, 2024

Allow grouping by scalar values. Needed for TPC-DS. In particular, query 27 uses this functionality.

Also a somewhat common pattern for building unions of aggregations from disparate tables.

@cpcloud cpcloud added this to the 9.2 milestone Jun 27, 2024
@cpcloud cpcloud added feature Features or general enhancements ux User experience related issues labels Jun 27, 2024
@cpcloud cpcloud requested a review from jcrist June 27, 2024 12:45
@cpcloud cpcloud force-pushed the group-by-scalars branch from a935bf5 to 57e8d04 Compare June 27, 2024 13:11
@cpcloud cpcloud requested a review from gforsyth June 27, 2024 13:41
@cpcloud
Copy link
Member Author

cpcloud commented Jun 27, 2024

Clouds are passing:

cloud in 🌐 falcon in …/ibis on  group-by-scalars is 📦 v9.1.0 via 🐍 v3.10.14 via ❄️   impure (ibis-3.10.14-env) took 3s
❯ pytest -m 'bigquery or snowflake' --dist loadgroup -q -n 8 --snapshot-update
bringing up nodes...
.............................................................................................................................................................x.ssssssssssssssssssssss..x...... [  5%]
.............x..........x..........................................................................................................................................x.xx...x..................x [ 10%]
.xx.......xx.xx..xx.x...x..xxx.xx.x......xxxxxx.....x.x.......x...x........x....x.x...x....x.x..x.......x.x.x...x....x........x.........xx......x.....x.......x.xx.......................x..xx [ 15%]
x......x....x.....x...xxxx.x....xx..x...........x............xx....x.............................x......................xx.............................x..........x........x........x.x...x..x [ 20%]
xx...............x....x.......xxxx....xxx...........xx.x........x......x........x.x......x.............................................x........x...xxx......x.........x...x..........x....... [ 25%]
.......x...x...x..x.x.....x........x...x..xx..........xx.x...........x.................x................xx...x...........................x...x...x....x........x..x...............s....x...... [ 31%]
........s..................................s...........xxxxx..x.x.xxx.xx.xxxxxxxxxx.xxxxxxxxxx.xxxxxxx.xxxxxxxxxxxxxxxxxx.xxxxx.xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx [ 36%]
sxxxxxx.xxx..x...x......xx.x.sx...........xx.........xx.x......s......x...s......................x.xx..............................x.x.........x.x.x....xx.........x....x....x.x.............. [ 41%]
..x.x...............x.....x....x.........xxxx.....x.........x......x.....x.....................x....xxx.....x.s...x...x....x............x...................xx...xxxx.x....xx.x.......x...x.x. [ 46%]
....x.x.....x.........................x...................................x......x...x......x...x.....x.......x...........x.x..........x...x..................x.................x....x....x..x [ 51%]
..x............x....................x.............................................................................x..x..........................x.................................x........... [ 56%]
...x.......x......xx.......x.x.............................x..x..........................................................x..............xx...................xx....x.......x.............x.... [ 62%]
..........................x...................x.............x.................x..x.......x..xx....................x...x....x..x....x..x..x...............................x....x....xx......... [ 67%]
.......x............x.......x................x......xx.....................x.........x...............x.........x.......x.............x..x....x..x.........s................................... [ 72%]
.........s...................s...s.............xxxxxx.xx.x..x..x....x.x..x....x..x...x.xx..xxx..x.xxx...xxx..x.xxxxx......x.xxx.xx..x.xxx.xxx.x......xxx.xx..x..xxx.x.x..xxx.xx...xxxx....xx.x [ 77%]
x.....xx.........s........x.x......x..................x..............x....x..............x.x.x..x.xx.......x..x..x...x..........x............x...x.......x........x......x......x............. [ 82%]
..x.....xx...x...x..x...x.......x........x..x.xx.......xx............x......x.x..xx............x..xx.x.............x..x...x.s....x...................xxx....xx..x..x.xx.xx.x...............x.. [ 87%]
x.x......x....................x.x.............................................................s............................................................................................... [ 93%]
.......................................s...................................................................................................................................................... [ 98%]
................................x.................s.........s......                                                                                                                            [100%]
3085 passed, 40 skipped, 552 xfailed in 691.94s (0:11:31)

@cpcloud cpcloud merged commit 14f1821 into ibis-project:main Jun 27, 2024
78 checks passed
@cpcloud cpcloud deleted the group-by-scalars branch June 27, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements ux User experience related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants