Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add some basic cast tests #9461

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Conversation

NickCrews
Copy link
Contributor

discovered that casting arrays didn't work in druid when implementing #9458.
So I thought I was write down what I found.

Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Would you mind opening issues for these failures when you get a chance? No rush!

@cpcloud cpcloud added this to the 9.2 milestone Jun 30, 2024
@cpcloud cpcloud added tests Issues or PRs related to tests timestamps Issues related to the timestamp API labels Jun 30, 2024
@cpcloud cpcloud merged commit b880f9e into ibis-project:main Jun 30, 2024
80 checks passed
@cpcloud
Copy link
Member

cpcloud commented Jun 30, 2024

Ok, after seeing this fail on BigQuery and Snowflake I took a closer look at the test case and I think there are some problems that need to be corrected.

Reverting.

cpcloud added a commit that referenced this pull request Jun 30, 2024
gforsyth pushed a commit that referenced this pull request Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues or PRs related to tests timestamps Issues related to the timestamp API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants