Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ir): avoid deduplicating filters based solely on their name #9476

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jun 29, 2024

This PR fixes an issue where we were using unwrap_aliases to deduplicate and
enforce expressions by their name in filters.

That approach makes sense in the context of projections, but the name of
predicate expressions in a filter is irrelevant.

The solution was to continue to unwrap aliases but avoid deduplicating
expressions based on their name, and do it solely on the hash value of
expressions.

Closes #9474.

@cpcloud cpcloud added this to the 9.2 milestone Jun 29, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis internals Issues or PRs related to ibis's internal APIs labels Jun 29, 2024
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gforsyth gforsyth merged commit b35582e into ibis-project:main Jul 1, 2024
81 checks passed
@cpcloud cpcloud deleted the allow-duplicate-names-filter branch July 1, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis internals Issues or PRs related to ibis's internal APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: duplicate column names in filters leads to error
2 participants