Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(blog): add 1tb challenge on a laptop post #9487

Merged
merged 10 commits into from
Jul 4, 2024
Merged

docs(blog): add 1tb challenge on a laptop post #9487

merged 10 commits into from
Jul 4, 2024

Conversation

lostmygithubaccount
Copy link
Member

Description of changes

adds "1TB challenge on a laptop" follow-up benchmarking post

Issues closed

@lostmygithubaccount lostmygithubaccount added the docs Documentation related issues or PRs label Jul 1, 2024
@lostmygithubaccount
Copy link
Member Author

for discussion:

  • the gifs make this a bit large, I did attempt to keep them small and think they add value to the post
  • parts still WIP
  • open to general feedback on structure/whatever

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jul 1, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jul 1, 2024
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jul 1, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jul 1, 2024
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jul 1, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jul 1, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jul 1, 2024

Docs preview: https://pr-9487-22422123a804e5def35bbc163df462e098e7b4d9--ibis-quarto.netlify.app

@lostmygithubaccount
Copy link
Member Author

I'm going to re-run on Polars v1.0.0 since that's out

@lostmygithubaccount lostmygithubaccount marked this pull request as draft July 1, 2024 14:20
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jul 2, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jul 2, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jul 2, 2024

Docs preview: https://pr-9487-2c5d77fc7b39eef69e16dacbee0d80d871a87316--ibis-quarto.netlify.app

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jul 2, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jul 2, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jul 2, 2024

Docs preview: https://pr-9487-f3159a6af36ac5579df3d5bc404e997ccc68d58c--ibis-quarto.netlify.app

cpcloud
cpcloud requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

docs/posts/1tbc/index.qmd Show resolved Hide resolved
docs/posts/1tbc/index.qmd Outdated Show resolved Hide resolved
docs/posts/1tbc/index.qmd Outdated Show resolved Hide resolved
docs/posts/1tbc/index.qmd Show resolved Hide resolved
docs/posts/1tbc/index.qmd Outdated Show resolved Hide resolved
docs/posts/1tbc/index.qmd Outdated Show resolved Hide resolved
docs/posts/1tbc/index.qmd Outdated Show resolved Hide resolved
docs/posts/1tbc/index.qmd Outdated Show resolved Hide resolved
docs/posts/1tbc/index.qmd Outdated Show resolved Hide resolved
docs/posts/1tbc/index.qmd Outdated Show resolved Hide resolved
lostmygithubaccount and others added 3 commits July 2, 2024 09:21
@lostmygithubaccount @cpcloud
docs(blog): add 1tb challenge on a laptop post
2722dd2 
Apply suggestions from code review

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
@lostmygithubaccount
missed suggestion + fix code + refreeze
991df2d
@lostmygithubaccount
updates
ca8894d
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jul 2, 2024
@lostmygithubaccount lostmygithubaccount marked this pull request as ready for review July 2, 2024 17:05
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jul 2, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jul 2, 2024

Docs preview: https://pr-9487-ca8894d57167468f04ec0dc7d1e02d1319841f4b--ibis-quarto.netlify.app

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jul 2, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jul 2, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jul 2, 2024

Docs preview: https://pr-9487-e183a9494a5e1ac61e0bdd691a2c979927c138cc--ibis-quarto.netlify.app

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jul 2, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jul 2, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jul 2, 2024

Docs preview: https://pr-9487-73ae8bd065eb30c86a67c91c152fbc5578c08b6b--ibis-quarto.netlify.app

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jul 3, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jul 3, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jul 3, 2024

Docs preview: https://pr-9487-10b8b757783d5c3b7f72c6e9e24c2304cee439db--ibis-quarto.netlify.app

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jul 4, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jul 4, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jul 4, 2024

Docs preview: https://pr-9487-0ebcaff4b428da1a5baa626a48bfda619cb5292d--ibis-quarto.netlify.app

cpcloud
cpcloud reviewed Jul 4, 2024
View reviewed changes
docs/posts/1tbc/.gitignore
@@ -0,0 +1,4 @@
ibis-bench
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just dump these into docs/posts/.gitignore so we don't have to duplicate them?

cpcloud
cpcloud requested changes Jul 4, 2024
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about a possible missing ::: from a callout.

docs/posts/1tbc/index.qmd Show resolved Hide resolved
@cpcloud cpcloud added this to the 9.2 milestone Jul 4, 2024
cpcloud
cpcloud reviewed Jul 4, 2024
View reviewed changes
docs/posts/1tbc/index.qmd Outdated Show resolved Hide resolved
cpcloud
cpcloud requested changes Jul 4, 2024
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple remaining comments, but otherwise LGTM!

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jul 4, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jul 4, 2024
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jul 4, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jul 4, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jul 4, 2024

Docs preview: https://pr-9487-9fc1c13f4c1402cf91a0aa78a7b2f86ac07c68f6--ibis-quarto.netlify.app

@lostmygithubaccount lostmygithubaccount merged commit e33a4cc into ibis-project:main Jul 4, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
docs Documentation related issues or PRs
Projects
None yet
Milestone
9.2
Development

Successfully merging this pull request may close these issues.
2 participants
@lostmygithubaccount @cpcloud