Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clickhouse): support Date32 database type #9509

Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix(clickhouse): support Date32 database type #9509

merged 1 commit into from
Jul 3, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 3, 2024

Add missing support for ClickHouse Date32 type.

@cpcloud cpcloud added this to the 9.2 milestone Jul 3, 2024
@cpcloud cpcloud added feature Features or general enhancements clickhouse The ClickHouse backend labels Jul 3, 2024
@cpcloud cpcloud requested review from gforsyth and jcrist July 3, 2024 11:30
gforsyth
gforsyth approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gforsyth gforsyth merged commit efa6fb7 into ibis-project:main Jul 3, 2024
80 checks passed
@cpcloud cpcloud deleted the clickhouse-date32 branch July 3, 2024 12:53
@goldmedal goldmedal mentioned this pull request Jul 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gforsyth gforsyth gforsyth approved these changes

@jcrist jcrist Awaiting requested review from jcrist

Assignees
No one assigned
Labels
clickhouse The ClickHouse backend feature Features or general enhancements
Projects
None yet
Milestone
9.2
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @gforsyth