feat(api): add positional joins #9533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCrews
force-pushed
the
positional-join
branch
2 times, most recently
from
d85bff3 to
9fc0ce7
Compare
Hm, CI seems to think otherwise 😅 |
|
They're a thing in at least DuckDB and polars, so it seems ok to enable them to me. I would push back against a top-level |
gforsyth
reviewed
Jul 15, 2024
Fully agree. |
By luck or magic, the pandas and dask backends seem to just work with no modification.
cpcloud
approved these changes
Jul 15, 2024
cpcloud
approved these changes
Jul 15, 2024
|
Thank you all! |
|
Just when I need it, thank you all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9486.
Add positional join to duckdb, pandas, and dask backends.
Amazingly simple to implement, a big cheers to the previous developers that made this code so clean and easy to edit!
By luck or magic, the pandas and dask backends seem to just work with no modification!
Should this be documented somewhere? I hesitate to clutter up the examples with this simple example. Really, I think the better thing that ibis really needs is a how-to guide on joining, where someone actually goes deep into the weeds and explains how things work.