Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pyspark): set lower bound of pyspark to 3.3.3 to avoid maintenance burden of pytest collection hook #9606

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 16, 2024

Increase the lower bound of pyspark to avoid a big hack in test collection. Also reduces hacking around numpy imports when making those optional in #9564.

@cpcloud cpcloud added this to the 9.2 milestone Jul 16, 2024
@cpcloud cpcloud added tests Issues or PRs related to tests pyspark The Apache PySpark backend labels Jul 16, 2024
@cpcloud cpcloud force-pushed the pyspark-lower-bound-at-3.3.3 branch from 5bc2faa to e9af645 Compare July 16, 2024 13:28
Copy link
Contributor

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@cpcloud cpcloud changed the title pyspark lower bound at 3.3.3 fix(pyspark): set lower bound of pyspark to 3.3.3 to avoid maintenance burden of pytest collection hook Jul 16, 2024
@cpcloud cpcloud requested a review from gforsyth July 16, 2024 13:32
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gforsyth gforsyth enabled auto-merge (squash) July 16, 2024 13:40
@gforsyth gforsyth merged commit 97af53c into ibis-project:main Jul 16, 2024
83 of 84 checks passed
@cpcloud cpcloud deleted the pyspark-lower-bound-at-3.3.3 branch July 16, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pyspark The Apache PySpark backend tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants