fix(mssql): always pass port to pyodbc in host string
#9656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing a port as a separate keyword argument is broken on `pyodbc` for at least `ODBC Driver 18 for SQL Server`. Passing the port in the hostname, however, works for both `FreeTDS` and ODBC Driver 18, so we're just going to do that for now.
|
Loving how you hit an unrelated flaky MS SQL issue in this PR! Opened an issue earlier this morning for that: #9654. Looks like this case is a different test, though pyarrow is involved in both cases. |
cpcloud
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Passing a port as a separate keyword argument is broken on
pyodbcforat least
ODBC Driver 18 for SQL Server.Passing the port in the hostname, however, works for both
FreeTDSandODBC Driver 18, so we're just going to do that for now.
Issues closed