ci(mssql): adjust to new location of sqlcmd
#9681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
ci
cpcloud
changed the title
sqlcmd
cpcloud
force-pushed
the
fix-mssql-healthcheck
branch
from
95e4d72 to
b5c27a3
Compare
|
Passing MS SQL tests, merging to unblock other PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft updates images underneath existing tags, and apparently moves binaries around, which caused our healthcheck to fail.
This PR fixes that and hopefully somewhat future-proofs by looking under
/for an executable file calledsqlcmd. Hopefully they don't change the name of that command 😬I also had to add the innocuous-looking but consequential
-Cflag, which says "hey trust the server certificate".