test: remove broken
marker, better define notimpl
and notyet
#9688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired by #9535
The broken mark had the meaning of "this broke for some reason, but it wasn't the fault of this PR, so lets ignore it for now". I find this only meaningful in the context of that individual PR though: as soon as the PR is merged, the usefulness drops to near 0. I come across this mark as I'm reading code and I have no idea what action I should take. notimpl, notyet, and never are much more useful, they signal where the fault lies and what to do about it.
I went through and converted all the instances of broken to one of these other 3 marks. It was fairly fast and definitely error prone. I could see the argument for converting these all to plain xfails when we aren't sure. I'm not sure how bad it is for these marks to be incorrect.
I tweaked the prose that describes these 3 marks. I would love your editing of them.