Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(duckdb): support arbitrary url prefixes #9691

Merged
merged 1 commit into from
Jul 25, 2024
Merged

feat(duckdb): support arbitrary url prefixes #9691

merged 1 commit into from
Jul 25, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 24, 2024

Closes #9689.

@cpcloud cpcloud added feature Features or general enhancements duckdb The DuckDB backend labels Jul 24, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Jul 24, 2024

cc @cboettig if you want to give this a go

ncclementi
ncclementi approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@ncclementi ncclementi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cpcloud cpcloud merged commit 11af489 into ibis-project:main Jul 25, 2024
82 checks passed
@cpcloud cpcloud deleted the hf branch July 25, 2024 14:28
@cpcloud cpcloud added this to the 9.3 milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncclementi ncclementi ncclementi approved these changes

Assignees
No one assigned
Labels
duckdb The DuckDB backend feature Features or general enhancements
Projects
None yet
Milestone
9.3
Development

Successfully merging this pull request may close these issues.

bug: read_parquet mangles huggingface prefix
2 participants
@cpcloud @ncclementi