Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigquery): repr geospatial values in interactive mode #9712

Merged
merged 4 commits into from
Jul 30, 2024
Merged

fix(bigquery): repr geospatial values in interactive mode #9712

merged 4 commits into from
Jul 30, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 29, 2024

Fixes a bug in the BigQuery backend when looking at geospatial types in interactive mode.

@cpcloud cpcloud added bug Incorrect behavior inside of ibis geospatial Geospatial related functionality bigquery The BigQuery backend labels Jul 29, 2024
@cpcloud cpcloud requested a review from ncclementi July 29, 2024 14:27
@cpcloud cpcloud force-pushed the bigquery-geospatial-output-fix branch 3 times, most recently from 7e300d2 to 20f9ce9 Compare July 29, 2024 14:57
@cpcloud cpcloud added the ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI label Jul 29, 2024
@ibis-docs-bot ibis-docs-bot bot removed the ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI label Jul 29, 2024
@cpcloud cpcloud added the ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI label Jul 29, 2024
@ibis-docs-bot ibis-docs-bot bot removed the ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI label Jul 29, 2024
@cpcloud cpcloud force-pushed the bigquery-geospatial-output-fix branch from c4decf3 to e9128bf Compare July 29, 2024 16:51
ncclementi
ncclementi approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@ncclementi ncclementi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment asking for a bit more context but outside that it looks good.

@cpcloud cpcloud force-pushed the bigquery-geospatial-output-fix branch 2 times, most recently from 758d19e to 6695186 Compare July 30, 2024 16:30
@cpcloud cpcloud force-pushed the bigquery-geospatial-output-fix branch from 6695186 to dc80b74 Compare July 30, 2024 16:32
@cpcloud
Copy link
Member Author

cpcloud commented Jul 30, 2024

Oops, rebased, the comment is here.

@cpcloud cpcloud added the ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI label Jul 30, 2024
@ibis-docs-bot ibis-docs-bot bot removed the ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI label Jul 30, 2024
@cpcloud cpcloud merged commit bd8c93f into ibis-project:main Jul 30, 2024
88 checks passed
@cpcloud cpcloud deleted the bigquery-geospatial-output-fix branch July 30, 2024 16:58
@cpcloud cpcloud added this to the 9.3 milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncclementi ncclementi ncclementi approved these changes

Assignees
No one assigned
Labels
bigquery The BigQuery backend bug Incorrect behavior inside of ibis geospatial Geospatial related functionality
Projects
None yet
Milestone
9.3
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @ncclementi