test(arrays): remove unnecessary series construction in test_array_remove
#9741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
force-pushed
the
test-array-remove
branch
from
6f8dedb to
caa0f8f
Compare
|
Reflecting on this a bit, I think the handwritten expected values are more maintainable and easy to understand. I'll clean up the test body bit though. For example, I don't think we need to construct a series for the expected values. |
cpcloud
force-pushed
the
test-array-remove
branch
from
caa0f8f to
67869b2
Compare
cpcloud
changed the title
test_array_remove
cpcloud
added
refactor
cpcloud
force-pushed
the
test-array-remove
branch
from
67869b2 to
0f3570e
Compare
cpcloud
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #9089, I think this is a bit more intuitive