Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snowflake): bring back where filter support in group_concat; fix array_agg ordering #9758

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Aug 3, 2024

Fixes two bugs introduced in #9729.

  • where handling was accidentally removed. This PR brings it back.
  • array_agg must be ordered using WITHIN GROUP, it doesn't accept a trailing ORDER BY in the call.

@cpcloud cpcloud added bug Incorrect behavior inside of ibis snowflake The Snowflake backend ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI labels Aug 3, 2024
@ibis-docs-bot ibis-docs-bot bot removed the ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI label Aug 3, 2024
@cpcloud cpcloud changed the title fix(snowflake): bring back where filter support in group_concat fix(snowflake): bring back where filter support in group_concat; fix array_agg ordering Aug 3, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Aug 3, 2024

Locally all green, merging:

…/ibis on  snowflake-fix-order is 📦 v9.2.0 via 🐍 v3.10.14 via ❄️   impure (ibis-3.10.14-env)
❯ pytest -m snowflake -n 8 --dist loadgroup -q
bringing up nodes...
..x.x........x...x..................x..x....x..x..x............xx.....x....x...x........x....x...x...xx....x.x...........xx...x........x............x.....xx.......x..........x.....x......... [ 10%]
x...x.......x.............s......x.x....x....x...............................xxxxxxxxxxx..x................x......................x.x.......................x.x.....x.....x....x.x...x.xx...x. [ 20%]
x...xxx.x...xxx..x..x..x...xx.xx...x.x.xx.xx....xxxxxxxxxxxxxxx.x.........xx..x..xx...x.x.xx.xxxxx...x...x.x......x..xxxs...x..........x......................x........x...............x....x. [ 30%]
..........x..x.........x.....x.......................x....x..............x.......................x..x......xx........x.......................................x....x...........x............... [ 41%]
...x.x...x.............x.................x......x...........x......xx.x...x................................x...x.......x..x........x.......xx..xx.....x.x.......x.........xx........x......... [ 51%]
...s.....................x..................................................s...x.....x..xs.xx..s.................................x.x............x............................................ [ 61%]
............x..............................x.......x..x.......x..x.xx.x....x..........xx.............................x..x..x...............x.................x....x........x...........x.....x [ 72%]
...............................................x.............x........................................x................x..........x................................x..................x....... [ 82%]
.......x.................................................x.................................xx....xxx.....xx.x..xx.x.x.xx.x.x............s..................................................... [ 92%]
........s..s..................................................................................................................s..                                                              [100%]
1606 passed, 10 skipped, 223 xfailed in 191.81s (0:03:11)

@cpcloud cpcloud merged commit 6e7e4de into ibis-project:main Aug 3, 2024
82 checks passed
@cpcloud cpcloud deleted the snowflake-fix-order branch August 3, 2024 12:05
@cpcloud cpcloud added this to the 9.3 milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis snowflake The Snowflake backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant