Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(postgres): handle enums by delegating to the parent class #9769

Merged
merged 3 commits into from
Aug 5, 2024
Merged

fix(postgres): handle enums by delegating to the parent class #9769

merged 3 commits into from
Aug 5, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Aug 5, 2024

Handle postgres enum types as unknown. Closes #9295.

@cpcloud cpcloud added bug Incorrect behavior inside of ibis tests Issues or PRs related to tests postgres The PostgreSQL backend datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) labels Aug 5, 2024
@cpcloud cpcloud requested a review from gforsyth August 5, 2024 11:44
@cpcloud cpcloud changed the title fix(postgres): handle enums by delegating to the parent class type parsing implementation fix(postgres): handle enums by delegating to the parent class Aug 5, 2024
gforsyth
gforsyth approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gforsyth gforsyth merged commit 3f01075 into ibis-project:main Aug 5, 2024
82 checks passed
@cpcloud cpcloud deleted the postgres-enum branch August 5, 2024 13:46
@cpcloud cpcloud added this to the 9.3 milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gforsyth gforsyth gforsyth approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior inside of ibis datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) postgres The PostgreSQL backend tests Issues or PRs related to tests
Projects
None yet
Milestone
9.3
Development

Successfully merging this pull request may close these issues.

bug: Failed to load Postgres table containing ENUM
2 participants
@cpcloud @gforsyth