Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depr(api): deprecate StructValue.destructure API #9824

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

deepyaman
Copy link
Contributor

@deepyaman deepyaman commented Aug 13, 2024

Description of changes

Deprecate StructValue.destructure in favor of StructValue.lift or Table.unpack.

@deepyaman deepyaman force-pushed the depr/api/destructure branch from 9ed5c64 to 229fa3c Compare August 13, 2024 21:05
@deepyaman deepyaman marked this pull request as ready for review August 13, 2024 21:18
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this file seems to only be running on pandas, Dask, and PySpark backends for some reason...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because those are historically the only backends that supported the vectorized UDF API.

@cpcloud cpcloud merged commit 98c5c76 into ibis-project:main Aug 13, 2024
84 checks passed
@cpcloud cpcloud added the deprecation Issues or PRs related to deprecating APIs label Aug 13, 2024
@deepyaman deepyaman deleted the depr/api/destructure branch August 13, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Issues or PRs related to deprecating APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants