-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency datafusion to v40 #9884
Conversation
else: | ||
# datafusion 40.1.0 has a bug where SessionContext requires | ||
# both SessionConfig and RuntimeConfig be provided. | ||
self.con = SessionContext(df_config, RuntimeConfig()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working around an upstream bug introduced in this release, see apache/datafusion-python#827.
), | ||
True, | ||
], | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these xfail removals are due to this upstream bug (apache/datafusion#10878) being resolved. In some places we had a version-checked xfail, while in others we were always xfailing. Since there were multiple bad versions with the bug, I opted to do the easy thing and just remove all the xfails rather than messing with version checks. We don't do version checks for other non-local backends, so this seems fine to me.
@@ -1353,6 +1352,7 @@ def test_26(catalog_sales, customer_demographics, date_dim, item, promotion): | |||
|
|||
|
|||
@tpc_test("ds") | |||
@pytest.mark.notyet(["datafusion"], reason="Failed to plan") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new bug, I'll file an upstream issue when I get a chance to narrow down a reproducer.
2349ba3
to
e7ac892
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
want to rebase merge this to capture the datafusion fixes in the release notes? |
This PR contains the following updates:
>=0.6,<40
->>=0.6,<41
Release Notes
apache/datafusion-python (datafusion)
v40.1.0
Compare Source
Configuration
📅 Schedule: Branch creation - "after 10pm every weekday,every weekend,before 5am every weekday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.