Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency datafusion to v40 #9884

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 21, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
datafusion (source) >=0.6,<40 -> >=0.6,<41 age adoption passing confidence

Release Notes

apache/datafusion-python (datafusion)

v40.1.0

Compare Source


Configuration

📅 Schedule: Branch creation - "after 10pm every weekday,every weekend,before 5am every weekday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added datafusion The Apache DataFusion backend dependencies Issues or PRs related to dependencies labels Aug 21, 2024
else:
# datafusion 40.1.0 has a bug where SessionContext requires
# both SessionConfig and RuntimeConfig be provided.
self.con = SessionContext(df_config, RuntimeConfig())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working around an upstream bug introduced in this release, see apache/datafusion-python#827.

),
True,
],
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these xfail removals are due to this upstream bug (apache/datafusion#10878) being resolved. In some places we had a version-checked xfail, while in others we were always xfailing. Since there were multiple bad versions with the bug, I opted to do the easy thing and just remove all the xfails rather than messing with version checks. We don't do version checks for other non-local backends, so this seems fine to me.

@@ -1353,6 +1352,7 @@ def test_26(catalog_sales, customer_demographics, date_dim, item, promotion):


@tpc_test("ds")
@pytest.mark.notyet(["datafusion"], reason="Failed to plan")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new bug, I'll file an upstream issue when I get a chance to narrow down a reproducer.

@jcrist jcrist force-pushed the renovate/datafusion-40.x branch from 2349ba3 to e7ac892 Compare August 21, 2024 05:15
Copy link
Contributor Author

renovate bot commented Aug 21, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@gforsyth
Copy link
Member

want to rebase merge this to capture the datafusion fixes in the release notes?

@cpcloud cpcloud merged commit 88f78da into main Aug 21, 2024
84 checks passed
@cpcloud cpcloud deleted the renovate/datafusion-40.x branch August 21, 2024 13:40
cpcloud pushed a commit that referenced this pull request Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion The Apache DataFusion backend dependencies Issues or PRs related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants