Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depr(expr-api): deprecate useless has_name method #9901

Merged
merged 1 commit into from
Aug 22, 2024
Merged

depr(expr-api): deprecate useless has_name method #9901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ibis/expr/types/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from ibis.config import _default_backend
from ibis.config import options as opts
from ibis.expr.format import pretty
from ibis.util import experimental
from ibis.util import deprecated, experimental

if TYPE_CHECKING:
from collections.abc import Iterator, Mapping
Expand Down Expand Up @@ -182,6 +182,11 @@ def __bool__(self) -> bool:

__nonzero__ = __bool__

@deprecated(
instead="remove any usage of `has_name`, since it is always `True`",
as_of="9.4",
removed_in="10.0",
)
def has_name(self):
"""Check whether this expression has an explicit name."""
return hasattr(self._arg, "name")
Expand Down
2 changes: 1 addition & 1 deletion ibis/expr/types/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def name(self, name):
# TODO(kszucs): shouldn't do simplification here, but rather later
# when simplifying the whole operation tree
# the expression's name is idendical to the new one
if self.has_name() and self.get_name() == name:
if self.get_name() == name:
return self

if isinstance(self.op(), ops.Alias):
Expand Down
Loading