Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oracle): implement current_catalog and current_database correctly #9918

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Aug 25, 2024

Fixes some hacks around current_catalog and current_database for the Oracle backend

@cpcloud cpcloud changed the title cleanup oracle database fix(oracle): implement current_catalog and current_database correctly Aug 25, 2024
Copy link
Contributor

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@cpcloud cpcloud force-pushed the cleanup-oracle-database branch from 02a76d4 to fa05938 Compare August 25, 2024 23:19
@cpcloud cpcloud added refactor Issues or PRs related to refactoring the codebase tests Issues or PRs related to tests datafusion The Apache DataFusion backend oracle The Oracle backend labels Aug 25, 2024
@cpcloud cpcloud added this to the 9.4 milestone Aug 25, 2024
@cpcloud cpcloud requested a review from gforsyth August 26, 2024 13:16
@gforsyth gforsyth merged commit 4fdb707 into ibis-project:main Aug 26, 2024
81 checks passed
@cpcloud cpcloud deleted the cleanup-oracle-database branch August 26, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion The Apache DataFusion backend oracle The Oracle backend refactor Issues or PRs related to refactoring the codebase tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants