Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(polars): use drop_table when cleaning the cache and remove duplicated _remove_table method #9922

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Aug 26, 2024

Fixes an issue in the polars backend where tables were still visible in SQL queries after being dropped. Ripped out of #9903.

@cpcloud cpcloud added this to the 9.4 milestone Aug 26, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis polars The polars backend labels Aug 26, 2024
@cpcloud cpcloud requested a review from jcrist August 26, 2024 14:38
@cpcloud cpcloud force-pushed the ensure-polars-drop-removes-sql-visible-tables branch from baae6da to d6e6e10 Compare August 26, 2024 14:39
Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

ibis/backends/tests/errors.py Show resolved Hide resolved
@cpcloud cpcloud enabled auto-merge (squash) August 26, 2024 17:22
@cpcloud cpcloud merged commit ce51941 into ibis-project:main Aug 26, 2024
81 checks passed
@cpcloud cpcloud deleted the ensure-polars-drop-removes-sql-visible-tables branch August 26, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis polars The polars backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants