-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(tpcds): add queries 72-74 #9933
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🐚 pytest -m snowflake ibis/backends/tests/tpc/ds/test_queries.py::test_72 -v
================================ test session starts ================================
platform linux -- Python 3.10.14, pytest-8.3.2, pluggy-1.5.0 -- /nix/store/qr6ish4s0mqa2lwna2b2gijja29plxpd-python3-3.10.14-env/bin/python3.10
cachedir: .pytest_cache
Using --randomly-seed=3806189695
benchmark: 4.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
hypothesis profile 'dev' -> deadline=None, max_examples=50, suppress_health_check=[HealthCheck.too_slow], database=DirectoryBasedExampleDatabase(PosixPath('/home/gil/github.com/ibis-project/ibis/.hypothesis/examples'))
rootdir: /home/gil/github.com/ibis-project/ibis
configfile: pyproject.toml
plugins: pytest_httpserver-1.1.0, snapshot-0.9.0, anyio-4.4.0, randomly-3.15.0, mock-3.14.0, benchmark-4.0.0, timeout-2.3.1, cov-5.0.0, repeat-0.9.3, clarity-1.0.1, xdist-3.6.1, hypothesis-6.111.2
collected 20 items / 19 deselected / 1 selected
ibis/backends/tests/tpc/ds/test_queries.py::test_72[snowflake] PASSED [100%]
========================= 1 passed, 19 deselected in 22.92s ========================= |
gforsyth
changed the title
test(tpcds): add query 72
test(tpcds): add queries 72 and 73
Aug 26, 2024
gforsyth
changed the title
test(tpcds): add queries 72 and 73
test(tpcds): add queries 72-74
Aug 26, 2024
Turns out the syntax error was found, worked-around, fixed and then forgotten-to-be-cleaned-up-based-on-my-own-note, all by yours truly 😒 |
I'll put up a PR to do that removal now. |
Ok, I altered the |
cpcloud
reviewed
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Trino syntax error on the join chains, and datafusion doesn't have date delta