Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(tpcds): add queries 72-74 #9933

Merged
merged 8 commits into from
Aug 27, 2024
Merged

test(tpcds): add queries 72-74 #9933

merged 8 commits into from
Aug 27, 2024

Conversation

gforsyth
Copy link
Member

Description of changes

Trino syntax error on the join chains, and datafusion doesn't have date delta

@gforsyth
Copy link
Member Author

🐚 pytest -m snowflake ibis/backends/tests/tpc/ds/test_queries.py::test_72 -v
================================ test session starts ================================
platform linux -- Python 3.10.14, pytest-8.3.2, pluggy-1.5.0 -- /nix/store/qr6ish4s0mqa2lwna2b2gijja29plxpd-python3-3.10.14-env/bin/python3.10
cachedir: .pytest_cache
Using --randomly-seed=3806189695
benchmark: 4.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
hypothesis profile 'dev' -> deadline=None, max_examples=50, suppress_health_check=[HealthCheck.too_slow], database=DirectoryBasedExampleDatabase(PosixPath('/home/gil/github.com/ibis-project/ibis/.hypothesis/examples'))
rootdir: /home/gil/github.com/ibis-project/ibis
configfile: pyproject.toml
plugins: pytest_httpserver-1.1.0, snapshot-0.9.0, anyio-4.4.0, randomly-3.15.0, mock-3.14.0, benchmark-4.0.0, timeout-2.3.1, cov-5.0.0, repeat-0.9.3, clarity-1.0.1, xdist-3.6.1, hypothesis-6.111.2
collected 20 items / 19 deselected / 1 selected                                     

ibis/backends/tests/tpc/ds/test_queries.py::test_72[snowflake] PASSED    [100%]

========================= 1 passed, 19 deselected in 22.92s =========================

@gforsyth gforsyth changed the title test(tpcds): add query 72 test(tpcds): add queries 72 and 73 Aug 26, 2024
@gforsyth gforsyth changed the title test(tpcds): add queries 72 and 73 test(tpcds): add queries 72-74 Aug 26, 2024
@cpcloud
Copy link
Member

cpcloud commented Aug 27, 2024

Turns out the syntax error was found, worked-around, fixed and then forgotten-to-be-cleaned-up-based-on-my-own-note, all by yours truly 😒

@cpcloud
Copy link
Member

cpcloud commented Aug 27, 2024

I'll put up a PR to do that removal now.

@cpcloud
Copy link
Member

cpcloud commented Aug 27, 2024

Ok, I altered the d1.d_date + 5 bit in the SQL to be date_add(d_date, 5) which sqlglot knows how to transpile, and I put up #9941, which should get test_72 passing on trino.

@cpcloud cpcloud added the tests Issues or PRs related to tests label Aug 27, 2024
@cpcloud cpcloud added this to the 9.4 milestone Aug 27, 2024
@gforsyth gforsyth merged commit 335a538 into ibis-project:main Aug 27, 2024
81 checks passed
@gforsyth gforsyth deleted the tpch72 branch August 27, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants