Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clickhouse): workaround EXCEPT and INTERSECT generation in sqlglot; add tpcds query 87 #9959

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Aug 29, 2024

Add query 87 and workaround a bug in sqlglot (fixed upstream in tobymao/sqlglot#4007)

@cpcloud cpcloud added this to the 9.4 milestone Aug 29, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis tests Issues or PRs related to tests clickhouse The ClickHouse backend labels Aug 29, 2024
@cpcloud cpcloud requested a review from gforsyth August 29, 2024 14:09
@@ -1,4 +1,4 @@
SELECT count(*)
SELECT count(*) num_cool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@gforsyth gforsyth enabled auto-merge (squash) August 29, 2024 14:51
@gforsyth
Copy link
Member

I restarted the docs job once already and it's still failing. Things are not making sense today

@gforsyth gforsyth merged commit 910b8f5 into ibis-project:main Aug 30, 2024
81 checks passed
@cpcloud cpcloud deleted the tpc-ds-87 branch August 30, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis clickhouse The ClickHouse backend tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants