Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(backends): run backend doctests in CI #9970

Merged
merged 34 commits into from
Sep 11, 2024
Merged

ci(backends): run backend doctests in CI #9970

merged 34 commits into from
Sep 11, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Aug 30, 2024

Run backend doctests in CI during the usual backend test suite.

@cpcloud cpcloud added tests Issues or PRs related to tests ci Continuous Integration issues or PRs labels Aug 30, 2024
@cpcloud cpcloud force-pushed the backend-doctests branch 2 times, most recently from 5b66fe4 to 27b7bd1 Compare August 30, 2024 12:40
@gmcrocetti
Copy link
Contributor

👏 . LMK in case you need/want help breaking up into smaller tasks o/.

@cpcloud cpcloud added the docs Documentation related issues or PRs label Sep 11, 2024
@cpcloud cpcloud mentioned this pull request Sep 11, 2024
Closed
@cpcloud cpcloud force-pushed the backend-doctests branch 2 times, most recently from f5237df to 1ccc714 Compare September 11, 2024 13:23
@cpcloud cpcloud added this to the 9.5 milestone Sep 11, 2024
@gforsyth
Copy link
Member

Well, I'd say the doctests in the backend were a good idea, even if it's only turning up out-of-date reprs

@cpcloud
Copy link
Member Author

cpcloud commented Sep 11, 2024

@gforsyth Indeed!

Thanks @gmcrocetti for pushing on this one!

gforsyth
gforsyth approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@gforsyth gforsyth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go if CI is green

Thanks for leading the way here @gmcrocetti !

@cpcloud
Copy link
Member Author

cpcloud commented Sep 11, 2024

Lemme make sure clouds are clouding.

@cpcloud
Copy link
Member Author

cpcloud commented Sep 11, 2024

Not much going on in the way of ☁️ doctests, but all good nonetheless:

❯ just backend-doctests snowflake -q && just backend-doctests bigquery -q
..                                                                                                                                                                                                             [100%]
2 passed in 0.44s
.                                                                                                                                                                                                              [100%]
1 passed in 1.12s

@cpcloud cpcloud merged commit bac76ff into ibis-project:main Sep 11, 2024
82 checks passed
@cpcloud cpcloud deleted the backend-doctests branch September 11, 2024 14:18
ncclementi pushed a commit to ncclementi/ibis that referenced this pull request Sep 24, 2024
@cpcloud @gmcrocetti @ncclementi
ci(backends): run backend doctests in CI (ibis-project#9970)
11fb399 
Co-authored-by: Guilherme Martins Crocetti <24530683+gmcrocetti@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmcrocetti gmcrocetti gmcrocetti left review comments

@gforsyth gforsyth gforsyth approved these changes

Assignees
No one assigned
Labels
ci Continuous Integration issues or PRs docs Documentation related issues or PRs tests Issues or PRs related to tests
Projects
None yet
Milestone
9.5
Development

Successfully merging this pull request may close these issues.
3 participants
@cpcloud @gmcrocetti @gforsyth