Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(aliasing): remove the need for renaming after execution #9996

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 2, 2024

Removes some code for renaming, which we were only doing because of ops.DummyTable and was ultimately unnecessary if we unalias its operations like we are doing elsewhere.

@cpcloud cpcloud added this to the 9.4 milestone Sep 2, 2024
@cpcloud cpcloud added internals Issues or PRs related to ibis's internal APIs refactor Issues or PRs related to refactoring the codebase labels Sep 2, 2024
@cpcloud cpcloud force-pushed the cleanup-renaming branch 4 times, most recently from 9bed6b8 to 86787ba Compare September 2, 2024 14:10
@cpcloud
Copy link
Member Author

cpcloud commented Sep 3, 2024

Clouds are passing:

❯ pytest -m snowflake -n 8 --dist loadgroup --snapshot-update -q && pytest -m bigquery -n auto --dist loadgroup --snapshot-update -q
bringing up nodes...
.xxxxxxxxxx.........x.x...........................x.x..x..x.x...............................x..x..........x...................................................x...x.x......................... [ 10%]
...x...........x.....................x.................x..............................................................x......................x......x.......x..x...............xx............. [ 20%]
.........xx.........x.......xx.......x.x......x...x....xx....x.x......x..x.x....................x...x..x..xx...xxx.x...x.x.............xxxx.......x........x...........x.............x........ [ 30%]
...x........................x...............x..x.x.......x......................x..........x.....x....x..x...x............x.........x...........x..x......x....xx..x............x............. [ 40%]
.x...x.....................................x.................................x..............x......xx..................x.....................xx....x.....x.................................s.. [ 50%]
..............x...x...................................x..x.....x.....x............x....x.x..x...x.......x............x.....x..............................x........x.....x...............xx... [ 60%]
........x...s..................x...x.xx......x......xxx....xxx....x......x..x........................x............s.....x.......................................x.......x..................... [ 70%]
...............................................x..............x................................................x............................................................s.......s......... [ 80%]
.........s....x....x....x...xxx.x.x.xxxx.x.x...xxx..xxx..xxx.xxx.x...x.xxxx.x..xxxxxxx.x..xxxx..xxx.xx....xx.......x.x.x...x..xx..x.xxx..xxxxxxxxxxx.xx.xx....x............x..x............... [ 90%]
...................................................s.............s................................................................................s.s.....................                     [100%]
1647 passed, 10 skipped, 223 xfailed in 221.69s (0:03:41)
bringing up nodes...
sssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss.....x.......x.x................x....xsssssssssssssssssssss.....x.....................s.... [  9%]
x.............s...................s...............................................x....x.xx...xxx.....xxx............xxxxx.x.x....x......x.....xx...x..x...........x...x.x..x.x.......x.x....x [ 18%]
.....xxx.x....x....x...x..xxxx.....x..x..........x...x..x................x..x..............x........................x.x............x............x...........x..................x.....x.xxxx.x. [ 27%]
...xx.xx....x.x..x.x....x....xx.x.x....x...x.xxx..x..........x.x.........xx....x....x...xx.....................x....x..x.....x......x.............x...x...x....x...................x....x..... [ 36%]
..x...x..x......x.......................................xxx..x.......x.x......x........x.x.........x........................x..x....xx.......x......x....x..........x............x............ [ 45%]
.......x.x...............x.......x....x.......x.x.......x..xx....x......xx....X.xx.......x..xx.......x..x....x..x.x.x.......X.....x...x..Xx.x...........x...x....x..x....x...xX........x....X. [ 54%]
x........x.........x.........x..............s..........................................x..................x.x...xxx.....xxxx.xxxxxxxxxx..x.xxxxx.xxxxxxxxxx.xx.xxxxx.xx.xxxxxxxxxxxxxxxxxxxxxx [ 63%]
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx.xxxxxxxx.xxxxxxxx...xxxx.xx.xx..x.x..xx...x.x...x..x.....x...x...xx........x......................x.......................x..............x.. [ 72%]
.............................................................s.x.s........x.......x.x..x..x.x.s...x...........s.xx..........x........x............................x...........x............... [ 81%]
..........................x..........................................................................................................................x........................................ [ 90%]
.............................................................................................................................................................................................. [ 99%]
.................                                                                                                                                                                              [100%]
1633 passed, 128 skipped, 341 xfailed, 5 xpassed in 315.89s (0:05:15)

@cpcloud cpcloud enabled auto-merge (squash) September 3, 2024 10:31
@cpcloud cpcloud merged commit a0d7237 into ibis-project:main Sep 3, 2024
81 checks passed
@cpcloud cpcloud deleted the cleanup-renaming branch September 3, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Issues or PRs related to ibis's internal APIs refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants