Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sidebar): can hide divider and footer #176

Merged
merged 2 commits into from
Jan 25, 2017
Merged

feat(sidebar): can hide divider and footer #176

merged 2 commits into from
Jan 25, 2017

Conversation

pidupuis
Copy link
Collaborator

What kind of change does this PR introduce? (check one with "x")

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Description

  • Sidebar dividers can now be displayed or removed after each sidebar item.
  • Footer can be hidden.

Verification steps

Update the sidebar configuration part by changing divider value for the different items.

@pidupuis pidupuis requested review from iblh and neoFelhz January 23, 2017 06:48
@neoFelhz
Copy link
Collaborator

Maybe you can add missed icon configurations in _config.template.yml in this pull requeset,which was forgotten to add in pull #165

@pidupuis
Copy link
Collaborator Author

@neoFelhz Could you tell me which one are missing please?

@neoFelhz
Copy link
Collaborator

In _config.template.yml ,from line 109 to 127.
It should be:

# Sidebar Customize
sidebar:
    dropdown:
        Email Me:
            link: "#"
            icon: email
    homepage:
        use: true
        icon: home
    archives:
        use: true
        icon: inbox
    categories:
        use: false
        icon: chrome_reader_mode
    pages:
        #About:
            #link: "/about"
            #icon: person

I missed configure the three default icons。

@pidupuis
Copy link
Collaborator Author

@neoFelhz Oh ok sure :)

@pidupuis pidupuis merged commit 0bd542d into canary Jan 25, 2017
@pidupuis pidupuis deleted the feat/sidebar branch January 25, 2017 07:19
@iblh iblh mentioned this pull request Jan 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants