-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(footer_sns): add segmentfault #217
Conversation
Thank you for your contribututions! |
Now I set your branch to |
@cntanglijun 你的sf footer请尽量按照sf官方定义的logo来 |
Please change all picture format to svg expect for yours one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we are using svg now. Please update your sns icon as svg format.
Contributing rules
canary
. Then be sure to put thecanary
branch as the target for your pull request.Contributing rules
part from this descriptionWhat kind of change does this PR introduce? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")
Description
Add a new sns icon for segmentfault
Verification steps
No verification steps.