Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(footer_sns): add segmentfault #217

Closed
wants to merge 4 commits into from

Conversation

cntanglijun
Copy link
Contributor

Contributing rules

  • Fork the repo and create your branch from canary. Then be sure to put the canary branch as the target for your pull request.
  • Please be sure to follow the contributing guidelines, especially for commit message
  • Remove the Contributing rules part from this description
  • Fill out the other parts from this description

What kind of change does this PR introduce? (check one with "x")

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Description

Add a new sns icon for segmentfault


Verification steps

No verification steps.

@neoFelhz
Copy link
Collaborator

Thank you for your contribututions!
Anyway, please using canary branch as base branch when open a new PR. canary branch is used to test new feat code.

@neoFelhz neoFelhz changed the base branch from master to canary February 25, 2017 13:37
@neoFelhz
Copy link
Collaborator

neoFelhz commented Feb 25, 2017

Now I set your branch to canary.

@neoFelhz neoFelhz changed the title Add sns segmentfault feat(footer_sns): add segmentfault Feb 25, 2017
@AkarinServer
Copy link
Contributor

@cntanglijun 你的sf footer请尽量按照sf官方定义的logo来

@AkarinServer
Copy link
Contributor

Please change all picture format to svg expect for yours one
请将所有的png后缀更改为svg,因为我们已经全面采用svg格式的icon了,当然你的pr可以保留为png格式

Copy link
Collaborator

@neoFelhz neoFelhz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we are using svg now. Please update your sns icon as svg format.

@neoFelhz neoFelhz closed this Mar 28, 2017
@neoFelhz neoFelhz mentioned this pull request Apr 2, 2017
9 tasks
@cntanglijun cntanglijun deleted the add-sns-segmentfault branch April 3, 2017 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants