Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/fix(#345): add configuration of toc_linenumber support #346

Merged
merged 2 commits into from
May 15, 2017

Conversation

neoFelhz
Copy link
Collaborator

@neoFelhz neoFelhz commented May 12, 2017

Contributing rules

  • Fork the repo and create your branch from canary. Then be sure to put the canary branch as the target for your pull request.
  • Please be sure to follow the contributing guidelines, especially for commit message
  • Remove the Contributing rules part from this description
  • Fill out the other parts from this description

If you don't do so, we might change your pull request's title and using squash to merge your changed.

What kind of change does this PR introduce? (check one with "x")

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Description

Now users can configure whether the line_number of toc will show or not in front-matter

For example,the line_number of toc will show with the front-matter with toc_linenumber: true (and default value is true), and won't with toc_linenumber: false

I move the configuration to theme config file.


Verification steps

I have already run a test on all possible situation and it works.

@neoFelhz neoFelhz requested review from cubesky and iblh May 12, 2017 09:39
@neoFelhz neoFelhz closed this May 12, 2017
@neoFelhz neoFelhz reopened this May 13, 2017
@neoFelhz neoFelhz merged commit 57d2ce7 into canary May 15, 2017
@neoFelhz neoFelhz deleted the feat/toc branch May 15, 2017 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants